Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tags to aws_db_instance data source #10550

Merged
merged 1 commit into from
Nov 2, 2019
Merged

add tags to aws_db_instance data source #10550

merged 1 commit into from
Nov 2, 2019

Conversation

sean-zou
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2988

Release note for CHANGELOG:

Support tags for aws_db_instance data source

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDbInstanceDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDbInstanceDataSource_basic -timeout 120m
=== RUN   TestAccAWSDbInstanceDataSource_basic
=== PAUSE TestAccAWSDbInstanceDataSource_basic
=== CONT  TestAccAWSDbInstanceDataSource_basic
--- PASS: TestAccAWSDbInstanceDataSource_basic (607.59s)
PASS
ok  	github.com/sean-zou/terraform-provider-aws/aws	609.224s

@sean-zou sean-zou requested a review from a team October 18, 2019 18:12
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 18, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 2, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 2, 2019
bflad
bflad approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @sean-zou 🚀

--- PASS: TestAccAWSDbInstanceDataSource_basic (535.69s)

aws/data_source_aws_db_instance.go
@@ -313,5 +315,10 @@ func dataSourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error
return fmt.Errorf("Error setting vpc_security_groups attribute: %#v, error: %#v", vpcSecurityGroups, err)
}

// Fetch and save tags
if err := saveTagsRDS(conn, d, aws.StringValue(dbInstance.DBInstanceArn)); err != nil {
log.Printf("[WARN] Failed to save tags for RDS Instance (%s): %s", aws.StringValue(dbInstance.DBInstanceArn), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: In the future we will be requiring returning an error instead of just logging these 👍

@bflad bflad merged commit 8ed9b99 into hashicorp:master Nov 2, 2019
bflad added a commit that referenced this pull request Nov 2, 2019
@bflad
Update CHANGELOG for #10550
c16e3a6
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.

Support tags for aws_db_instance data source
2 participants
@sean-zou @bflad